Feature/helper resolver #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcardune
reviewed
Apr 18, 2017
CHANGELOG.md
Outdated
| ## [1.4.1] - 2017-04-18 | ||
|
|
||
| ### Added | ||
| - Added `helperResolver` config option to override the default helper resolution |
There was a problem hiding this comment.
I would just put this under the [Unreleased] section, and I'll update with a version number and date when I get around to making a release (which will hopefully be soon).
package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "type": "git", | |||
| "url": "git://github.com/pcardune/handlebars-loader.git" | |||
| }, | |||
| "version": "1.4.0", | |||
| "version": "1.4.1", | |||
There was a problem hiding this comment.
likewise ditch this change. I'll update when I make a release.
README.md
Outdated
| handlebarsLoader: { | ||
| helperResolver: function(helper, callback){ | ||
| // should pass the helper's path on disk to | ||
| // to the callback if one was find for the given parameter. |
There was a problem hiding this comment.
there is an extra "to" in here. Also replace "find" with "found".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
helperResolverconfig option to override the default helper resolution.This config option is implemented in the same way the
partialResolveris implemented and was added for the same reasons.